Obtain timeseries step information from dims or observed#5743
Merged
ricardoV94 merged 3 commits intopymc-devs:mainfrom May 6, 2022
Merged
Obtain timeseries step information from dims or observed#5743ricardoV94 merged 3 commits intopymc-devs:mainfrom
ricardoV94 merged 3 commits intopymc-devs:mainfrom
Conversation
ricardoV94
force-pushed
the
shape_from_dims_observed
branch
3 times, most recently
from
a7d9fde to
b7a6290
Compare
Codecov Report
@@ Coverage Diff @@
## main #5743 +/- ##
==========================================
- Coverage 89.22% 89.13% -0.09%
==========================================
Files 75 75
Lines 13824 13844 +20
==========================================
+ Hits 12334 12340 +6
- Misses 1490 1504 +14
|
Member
Author
|
We really need to sort out what's going with #5739, it's failing nearly every time |
ricardoV94
force-pushed
the
shape_from_dims_observed
branch
from
ff03fe7 to
4897cab
Compare
This is consistent with the meaning of steps in the GaussianRandomWalk and translates directly to the number of scan steps taken
ricardoV94
force-pushed
the
shape_from_dims_observed
branch
from
4897cab to
504da82
Compare
This was referenced May 5, 2022
michaelosthege
approved these changes
May 5, 2022
Member
michaelosthege
left a comment
michaelosthege
left a comment
There was a problem hiding this comment.
Looks really good!
I particularly like the test cases.
| and init.owner.op.ndim_supp == 0 | ||
| ): | ||
| raise TypeError("init must be a univariate distribution variable") | ||
| check_dist_not_registered(init) |
Member
There was a problem hiding this comment.
Can you add a comment what this line does?
Member
Author
There was a problem hiding this comment.
I think the function self documents itself well enough:
Lines 337 to 351 in 02897d1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #5690 so that steps can also be retrieved from observed and dims when possible.
Other changes:
pandas_to_arraytoconvert_observed_datastepsmore consistent with expectation / GRW